Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust zoom on search result focus #47

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Adjust zoom on search result focus #47

merged 1 commit into from
Nov 14, 2017

Conversation

akstuhl
Copy link
Contributor

@akstuhl akstuhl commented Nov 14, 2017

What does this PR do?

Adds a configuration setting called search_zoom_pad that decreases the intensity of the zoom-in when a search result is clicked. Clicking a result will still center the viewer on the corresponding line, but will add the specified amount to each end of the bounds that the viewer zooms to.

What issues does it address?

Closes #46

How to test

Enter a search term and click a result in the list. The viewer should center on the corresponding line, but not zoom in so far that the edges of the line's backdrop line up with the edges of the viewer frame. If you change the search_zoom_pad value in _config.yml to a higher value, search result clicks will cause a slighter zoom; if a lower value, a closer zoom.

Copy link
Member

@jamiefolsom jamiefolsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akstuhl looks and works great. 👍

@akstuhl akstuhl merged commit cf7f16f into master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set zoom level lower upon search result click
2 participants