Fix xbcloud out of range memory read #1538
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a memory out of bounds read when
chunk_name.size() < 21
- 2nd condition use negative index
- 2nd condition not evaluated
- 2nd condition using index 0, ok but useless if we want names longer than 21 chars
- 2nd condition not evaluated
- 2nd condition is not evaluated
- 2nd condition is evaluated with an index always > 0