Update s3.cc to add Content-MD5 header to V4 S3 api #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckblaze upload incase Object Lock is activated
|
|
|
Hi @vovler . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-MD5 header is required for the PutObject in case Object Lock is activated as per:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html
I've only tested with Backblaze's S3 V4 compatible API, which throws this error while uploading to a Object Locked bucket :
xbcloud: S3 error message: Missing required header for this request: Content-MD5So I'm not sure if Amazon S3 will throw the same error or not, but from their API docs, it seems to be required as well.
I've compiled the code to test the change with Backblaze and it's working as intended.