Fix uneffective BGAPI device open retry mechanism #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Merello <[email protected]>
uilyam
added a commit
to brilliantsole/pygatt
that referenced
this pull request
Jan 23, 2018
uilyam
added a commit
to brilliantsole/pygatt
that referenced
this pull request
Jan 23, 2018
This reverts commit c780d1f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually you have merged #144 but apparently it did not fix the reconnection problem I've tried to fix in #133 .
#144 does implement a logic that cause the retry not to happen on the first connection attempt, but just on the reconnections after reset, which is fine, but the reconnection mechanism itself seems still broken to me.
This is a respin of #133 that should fix the reconnection mechanism on the top of the new reconnection logic merged in #144