Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all existing event.rs files to use proto events. #3504

Open
Tracked by #3460
hdevalence opened this issue Dec 11, 2023 · 5 comments
Open
Tracked by #3460

Port all existing event.rs files to use proto events. #3504

hdevalence opened this issue Dec 11, 2023 · 5 comments
Assignees
Labels
_P-medium Medium priority _P-V1 Priority: slated for V1 release
Milestone

Comments

@hdevalence
Copy link
Member

Following the work in #3460 to define protobuf event handling, it would be good to convert the existing events:

We should then replace all existing events defined in the Penumbra application with Protobuf-based events. These events should be defined in the Proto module corresponding to the component that emits the event. Currently, there are only 12 events currently defined (VS Code search fn in files named event.rs), so this shouldn't be a huge lift.

Since any Protobuf message could in principle be encoded as an event this way, we should adopt a naming convention to distinguish messages defining events from messages defining other data. One possibility would be to name all of the event messages Event*. Using a prefix rather than a suffix means that all of the events will be grouped together when messages are sorted alphabetically.

In particular, porting over the DEX events will make them useful for trading bots (cf https://discord.com/channels/824484045370818580/1163684711667867678/1181748568135061514 )

@erwanor
Copy link
Member

erwanor commented Jan 12, 2024

Note to self, that we should also port the staking component events to use proto-event.

@erwanor
Copy link
Member

erwanor commented Jan 16, 2024

I will push this over the finish line before we release Testnet 65. I will first take care of staking component related items.

@hdevalence
Copy link
Member Author

Was this completed? We should ensure it's completed as part of V1 -- we can always add more events but changing events people are using will be difficult.

@hdevalence hdevalence added the _P-V1 Priority: slated for V1 release label Mar 22, 2024
@conorsch conorsch modified the milestone: v1 Mar 25, 2024
cratelyn added a commit that referenced this issue Apr 12, 2024
while looking around through files named `event.rs`, per the description
of #3504, i found that some of these files are empty. this commit
removes these empty files.
cratelyn added a commit that referenced this issue Apr 12, 2024
while looking around through files named `event.rs`, per the description
of #3504, i found that some of these files are empty. this commit
removes these empty files.
cratelyn added a commit that referenced this issue Apr 12, 2024
while looking around through files named `event.rs`, per the description
of #3504, i found that some of these files are empty. this commit
removes these empty files.
@erwanor
Copy link
Member

erwanor commented Apr 12, 2024

I ported over the DEX events, but got pulled in another direction before doing the rest of the codebase. I believe that @zbuc is tracking the staking events in #3797. I'm unassigning myself for now

@erwanor erwanor removed their assignment Apr 12, 2024
@aubrika aubrika added the _P-medium Medium priority label Apr 22, 2024
@aubrika aubrika added this to the Sprint 8 milestone May 30, 2024
@zbuc zbuc self-assigned this Jun 3, 2024
@aubrika aubrika modified the milestones: Sprint 8, Sprint 9 Jul 15, 2024
@zbuc
Copy link
Member

zbuc commented Jul 18, 2024

The only place using non-protobuf event types is now the IBC code. This will require defining protobuf event types in ibc-types

@aubrika aubrika modified the milestones: Sprint 9, Sprint 10 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_P-medium Medium priority _P-V1 Priority: slated for V1 release
Projects
Status: In progress
Status: In Progress (Already claimed)
Development

No branches or pull requests

5 participants