Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove everything unrelated to DataChannels #1

Open
81 tasks
aisouard opened this issue May 20, 2015 · 3 comments
Open
81 tasks

Remove everything unrelated to DataChannels #1

aisouard opened this issue May 20, 2015 · 3 comments

Comments

@aisouard
Copy link
Member

There are more than 3,000 files to build, the libwebrtc library only needs about 300 files because they've removed every dependencies to video and audio modules.

We should remove everything related to audio and video codecs.

Here's a list of every libraries compiled and needed by Peeracle, put a ☑️ when you've managed to remove a useless dependency.

  • libyuv.a
  • obj/webrtc/system_wrappers/libsystem_wrappers.a
  • obj/webrtc/system_wrappers/libmetrics_default.a
  • obj/webrtc/system_wrappers/libfield_trial_default.a
  • obj/webrtc/libjingle/xmllite/librtc_xmllite.a
  • obj/webrtc/libjingle/xmpp/librtc_xmpp.a
  • obj/webrtc/common_audio/libcommon_audio_sse2.a
  • obj/webrtc/common_audio/libcommon_audio.a
  • obj/webrtc/modules/libiLBC.a
  • obj/webrtc/modules/libvideo_processing_sse2.a
  • obj/webrtc/modules/libPCM16B.a
  • obj/webrtc/modules/libiSAC.a
  • obj/webrtc/modules/librtp_rtcp.a
  • obj/webrtc/modules/libG722.a
  • obj/webrtc/modules/libaudio_conference_mixer.a
  • obj/webrtc/modules/libvideo_render_module.a
  • obj/webrtc/modules/libwebrtc_utility.a
  • obj/webrtc/modules/libwebrtc_video_coding.a
  • obj/webrtc/modules/libaudio_processing_sse2.a
  • obj/webrtc/modules/libaudioproc_debug_proto.a
  • obj/webrtc/modules/libaudio_encoder_interface.a
  • obj/webrtc/modules/libvideo_processing.a
  • obj/webrtc/modules/libdesktop_capture_differ_sse2.a
  • obj/webrtc/modules/libvideo_render_module_internal_impl.a
  • obj/webrtc/modules/libCNG.a
  • obj/webrtc/modules/libred.a
  • obj/webrtc/modules/libG711.a
  • obj/webrtc/modules/libwebrtc_opus.a
  • obj/webrtc/modules/libaudio_processing.a
  • obj/webrtc/modules/libremote_bitrate_estimator.a
  • obj/webrtc/modules/libneteq.a
  • obj/webrtc/modules/video_coding/utility/libvideo_coding_utility.a
  • obj/webrtc/modules/video_coding/codecs/vp9/libwebrtc_vp9.a
  • obj/webrtc/modules/video_coding/codecs/vp8/libwebrtc_vp8.a
  • obj/webrtc/modules/libdesktop_capture.a
  • obj/webrtc/modules/libaudio_decoder_interface.a
  • obj/webrtc/modules/libiSACFix.a
  • obj/webrtc/modules/libvideo_capture_module_internal_impl.a
  • obj/webrtc/modules/libpaced_sender.a
  • obj/webrtc/modules/libaudio_coding_module.a
  • obj/webrtc/modules/libmedia_file.a
  • obj/webrtc/modules/libvideo_capture.a
  • obj/webrtc/modules/libaudio_device.a
  • obj/webrtc/modules/libvideo_capture_module.a
  • obj/webrtc/modules/libvideo_render.a
  • obj/webrtc/modules/libwebrtc_i420.a
  • obj/webrtc/modules/libbitrate_controller.a
  • obj/webrtc/libwebrtc.a
  • obj/webrtc/libwebrtc_common.a
  • obj/webrtc/common_video/libcommon_video.a
  • obj/webrtc/video_engine/libvideo_engine_core.a
  • obj/webrtc/sound/librtc_sound.a
  • obj/webrtc/base/librtc_base_approved.a
  • obj/webrtc/base/librtc_base.a
  • obj/webrtc/tools/libframe_editing_lib.a
  • obj/webrtc/tools/libvideo_quality_analysis.a
  • obj/webrtc/tools/libcommand_line_parser.a
  • obj/webrtc/p2p/libstunprober.a
  • obj/webrtc/p2p/librtc_p2p.a
  • obj/webrtc/voice_engine/libvoice_engine.a
  • obj/talk/libjingle_media.a
  • obj/talk/libjingle_peerconnection.a
  • obj/talk/libjingle_p2p.a
  • obj/chromium/src/third_party/usrsctp/libusrsctplib.a
  • obj/chromium/src/third_party/opus/libopus.a
  • obj/chromium/src/third_party/openmax_dl/dl/libopenmax_dl.a
  • obj/chromium/src/third_party/yasm/libgenperf_libs.a
  • obj/chromium/src/third_party/jsoncpp/libjsoncpp.a
  • obj/chromium/src/third_party/libsrtp/libsrtp.a
  • obj/chromium/src/third_party/libvpx/libvpx_intrinsics_sse4_1.a
  • obj/chromium/src/third_party/libvpx/libvpx_intrinsics_ssse3.a
  • obj/chromium/src/third_party/libvpx/libvpx_intrinsics_sse2.a
  • obj/chromium/src/third_party/libvpx/libvpx_intrinsics_mmx.a
  • obj/chromium/src/third_party/libvpx/libvpx.a
  • obj/chromium/src/third_party/libvpx/libvpx_intrinsics_avx2.a
  • obj/chromium/src/third_party/protobuf/libprotobuf_lite.a
  • obj/chromium/src/third_party/protobuf/libprotobuf_full_do_not_use.a
  • obj/chromium/src/third_party/boringssl/libboringssl.a
  • obj/chromium/src/third_party/icu/libicuuc.a
  • obj/chromium/src/third_party/libjpeg_turbo/libjpeg_turbo.a
  • obj/chromium/src/net/third_party/nss/libcrssl.a
@aisouard
Copy link
Member Author

It's compiling 851 files right now under Linux since a144c46, but libwebrtc is still building ~300, something's missing.

@aisouard
Copy link
Member Author

Reverted in 311be9c, we should treat issue #2 and #3 before optimizing this.

@aisouard
Copy link
Member Author

Edited with a list of libraries to remove.

aisouard pushed a commit that referenced this issue Jun 16, 2015
Solve TSan warning about unlocking an unlocked mutex.
e14e5f4 
In my previous cl, https://webrtc-codereview.appspot.com/52479004/, there is 'UnLock()' left when we switched to scoped lock, which will cause TSan warning sometimes.
===========================================================
WARNING: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong thread) (pid=9981)
#0 pthread_mutex_unlock <null> (libjingle_peerconnection_unittest+0x00000046836f)
#1 webrtc::CriticalSectionPosix::Leave() webrtc/system_wrappers/source/critical_section_posix.cc:39:10 (libjingle_peerconnection_unittest+0x000000bc368d)
#2 ~CriticalSectionScoped webrtc/system_wrappers/interface/critical_section_wrapper.h:46:48 (libjingle_peerconnection_unittest+0x000000a61fcb)
#3 webrtc::AudioDeviceLinuxPulse::RecThreadProcess() webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:3003 (libjingle_peerconnection_unittest+0x000000a61fcb)
===========================================================

BUG=3056
TEST=bots
[email protected]

Review URL: https://webrtc-codereview.appspot.com/56439004

Cr-Commit-Position: refs/heads/master@{#9282}
aisouard pushed a commit that referenced this issue Jun 17, 2015
Revert of Whitespace change (patchset #1 id:1 of https://codereview.w…
f050b9d 
…ebrtc.org/1182933006/)

Reason for revert:
Testing the revert button with our new CQ.

Original issue's description:
> Whitespace change to test CQ
>
> BUG=
> TBR=
>
> Committed: https://crrev.com/fe23090c6144b2c03fce3c4f05fb6d469415d41c
> Cr-Commit-Position: refs/heads/master@{#9440}

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.webrtc.org/1180143006

Cr-Commit-Position: refs/heads/master@{#9447}
aisouard pushed a commit that referenced this issue Jun 17, 2015
Revert of Allow intelligibility to compile in apm (patchset #1 id:1 of …
c555b99 
…https://codereview.webrtc.org/1182323005/)

Reason for revert:
Breaking the build bots: https://build.chromium.org/p/client.webrtc/builders/Mac32%20Release%20%5Blarge%20tests%5D/builds/4544

Fails to compile with this error:

../../webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.cc:218:25: error: no member named 'accumulate' in namespace 'std'
    power_target = std::accumulate(clear_variance_.variance(),

Original issue's description:
> Allow intelligibility to compile in apm
>
> - Added files to gyp and BUILD
> - Made minor fixes to get everything to compile
>     and intelligibility_proc to run
> - Added comments
> - Auto-reformatting
>
> Original cl is at: https://webrtc-codereview.appspot.com/57579004/
>
> [email protected]
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/b7553dfdbb1ca7779eb0d80b5f509523c9b00086

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.webrtc.org/1187033005

Cr-Commit-Position: refs/heads/master@{#9455}
aisouard pushed a commit that referenced this issue Jul 15, 2015
@shishkander
Revert of Fix PRESUBMIT.py after disabling CQ. (patchset #1 id:1 of h…
d5d52bb 
…ttps:https://codereview.webrtc.org/1192673003/)

Reason for revert:
CQ-Rietveld combination now supports webrtc custom domain.

Original issue's description:
> Fix PRESUBMIT.py after disabling CQ.
>
> The disabling of CQ in https://codereview.webrtc.org/1177243003/
> broke PRESUBMIT.py since it's trying to read cq.cfg.
>
> BUG=501332
> [email protected]
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/141725f50fa4223ce2f9e84500971a44d7720c03

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501332

Review URL: https://codereview.webrtc.org/1190283003

Cr-Commit-Position: refs/heads/master@{#9476}
aisouard pushed a commit that referenced this issue Jul 16, 2015
@shishkander
Revert of Fix PRESUBMIT.py after disabling CQ. (patchset #1 id:1 of h…
04465d2 
…ttps:https://codereview.webrtc.org/1192673003/)

Reason for revert:
CQ-Rietveld combination now supports webrtc custom domain.

Original issue's description:
> Fix PRESUBMIT.py after disabling CQ.
>
> The disabling of CQ in https://codereview.webrtc.org/1177243003/
> broke PRESUBMIT.py since it's trying to read cq.cfg.
>
> BUG=501332
> [email protected]
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/141725f50fa4223ce2f9e84500971a44d7720c03

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501332

Review URL: https://codereview.webrtc.org/1190283003

Cr-Commit-Position: refs/heads/master@{#9476}
aisouard pushed a commit that referenced this issue Sep 4, 2015
Revert of Use RtcpPacket to send REMB in RtcpSender (patchset #1 id:1…
141c595 
… of https://codereview.webrtc.org/1290573004/ )

Reason for revert:
A few bots started failing rtc_unittests after this was commited. Ex https://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5048

Original issue's description:
> Use RtcpPacket to send REMB in RtcpSender
>
> BUG=webrtc:2450
> [email protected]
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/35ab4baa20a730de71b390008900a16563cbbe8e

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:2450

Review URL: https://codereview.webrtc.org/1300863002

Cr-Commit-Position: refs/heads/master@{#9723}
aisouard pushed a commit that referenced this issue Sep 4, 2015
Revert of Revert "Remove CpuMonitor and related, unused, code." (patc…
048e80c 
…hset #1 id:1 of https://codereview.webrtc.org/1287913004/ )

Reason for revert:
(retrying with my webrtc account...)
The reason for reverting is: Re-landing the change that removes the CpuMonitor class after having fixed the build issue in Chromium..

Original issue's description:
> Revert "Remove CpuMonitor and related, unused, code."
>
> This reverts commit 1a24012.
>
> [email protected],[email protected]
> BUG=
>
> This breaks
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux/builds/20148/steps/compile/logs/stdio
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/a472e968c95fb14e63ec42f453551d0967573ea8

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.webrtc.org/1290033005

Cr-Commit-Position: refs/heads/master@{#9733}
aisouard pushed a commit that referenced this issue Sep 4, 2015
Reland of Use RtcpPacket to send REMB in RtcpSender (patchset #1 id:1…
dd4edc5 
… of https://codereview.webrtc.org/1300863002/ )

Reason for revert:
This wasn't the cause of the breakage. Re-reverting.
https://code.google.com/p/webrtc/issues/detail?id=4923

Original issue's description:
> Revert of Use RtcpPacket to send REMB in RtcpSender (patchset #1 id:1 of https://codereview.webrtc.org/1290573004/ )
>
> Reason for revert:
> A few bots started failing rtc_unittests after this was commited. Ex https://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5048
>
> Original issue's description:
> > Use RtcpPacket to send REMB in RtcpSender
> >
> > BUG=webrtc:2450
> > [email protected]
> >
> > Committed: https://chromium.googlesource.com/external/webrtc/+/35ab4baa20a730de71b390008900a16563cbbe8e
>
> [email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:2450
>
> Committed: https://crrev.com/141c5951f4beda868797c2746002a4b1b267ab2a
> Cr-Commit-Position: refs/heads/master@{#9723}

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:2450

Review URL: https://codereview.webrtc.org/1309723002

Cr-Commit-Position: refs/heads/master@{#9754}
aisouard pushed a commit that referenced this issue Sep 4, 2015
Revert of Excluding two troublesome trybots from the CQ config. (patc…
d4563f4 
…hset #1 id:1 of https://codereview.webrtc.org/1310953006/ )

Reason for revert:
Both bots are now back online. Let's try enabling them again.

Original issue's description:
> Excluding two troublesome trybots from the CQ config.
>
> Temporary measurement to allow landing of a queue of CLs.
>
> BUG=524352, 526625
> [email protected]
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/fa7cb8eaa72a33fd8d790674f98b35afbe9d863c

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=524352, 526625

Review URL: https://codereview.webrtc.org/1305983005

Cr-Commit-Position: refs/heads/master@{#9842}
aisouard pushed a commit that referenced this issue Sep 15, 2015
Revert of purge nss files and dependencies (patchset #1 id:1 of https…
9eb1365 
…:https://codereview.webrtc.org/1313233005/ )

Reason for revert:
It looks like this broke the FYI bots. I tried updating libjingle_nacl.gyp, but the IOS build still failed because in Chrome it's configured to use NSS. See https://codereview.chromium.org/1316863012/.

Original issue's description:
> purge nss files and dependencies
>
> BUG=webrtc:4497
>
> Committed: https://crrev.com/5647a2cf3db888195c928a1259d98f72f6ecbc15
> Cr-Commit-Position: refs/heads/master@{#9862}

[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4497

Review URL: https://codereview.webrtc.org/1311843006

Cr-Commit-Position: refs/heads/master@{#9867}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aisouard