-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove everything unrelated to DataChannels #1
Comments
It's compiling 851 files right now under Linux since a144c46, but libwebrtc is still building ~300, something's missing. |
Edited with a list of libraries to remove. |
aisouard
pushed a commit
that referenced
this issue
Jun 16, 2015
In my previous cl, https://webrtc-codereview.appspot.com/52479004/, there is 'UnLock()' left when we switched to scoped lock, which will cause TSan warning sometimes. =========================================================== WARNING: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong thread) (pid=9981) #0 pthread_mutex_unlock <null> (libjingle_peerconnection_unittest+0x00000046836f) #1 webrtc::CriticalSectionPosix::Leave() webrtc/system_wrappers/source/critical_section_posix.cc:39:10 (libjingle_peerconnection_unittest+0x000000bc368d) #2 ~CriticalSectionScoped webrtc/system_wrappers/interface/critical_section_wrapper.h:46:48 (libjingle_peerconnection_unittest+0x000000a61fcb) #3 webrtc::AudioDeviceLinuxPulse::RecThreadProcess() webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:3003 (libjingle_peerconnection_unittest+0x000000a61fcb) =========================================================== BUG=3056 TEST=bots [email protected] Review URL: https://webrtc-codereview.appspot.com/56439004 Cr-Commit-Position: refs/heads/master@{#9282}
aisouard
pushed a commit
that referenced
this issue
Jun 17, 2015
…ebrtc.org/1182933006/) Reason for revert: Testing the revert button with our new CQ. Original issue's description: > Whitespace change to test CQ > > BUG= > TBR= > > Committed: https://crrev.com/fe23090c6144b2c03fce3c4f05fb6d469415d41c > Cr-Commit-Position: refs/heads/master@{#9440} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.webrtc.org/1180143006 Cr-Commit-Position: refs/heads/master@{#9447}
aisouard
pushed a commit
that referenced
this issue
Jun 17, 2015
…https://codereview.webrtc.org/1182323005/) Reason for revert: Breaking the build bots: https://build.chromium.org/p/client.webrtc/builders/Mac32%20Release%20%5Blarge%20tests%5D/builds/4544 Fails to compile with this error: ../../webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.cc:218:25: error: no member named 'accumulate' in namespace 'std' power_target = std::accumulate(clear_variance_.variance(), Original issue's description: > Allow intelligibility to compile in apm > > - Added files to gyp and BUILD > - Made minor fixes to get everything to compile > and intelligibility_proc to run > - Added comments > - Auto-reformatting > > Original cl is at: https://webrtc-codereview.appspot.com/57579004/ > > [email protected] > > Committed: https://chromium.googlesource.com/external/webrtc/+/b7553dfdbb1ca7779eb0d80b5f509523c9b00086 [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.webrtc.org/1187033005 Cr-Commit-Position: refs/heads/master@{#9455}
aisouard
pushed a commit
that referenced
this issue
Jul 15, 2015
…ttps:https://codereview.webrtc.org/1192673003/) Reason for revert: CQ-Rietveld combination now supports webrtc custom domain. Original issue's description: > Fix PRESUBMIT.py after disabling CQ. > > The disabling of CQ in https://codereview.webrtc.org/1177243003/ > broke PRESUBMIT.py since it's trying to read cq.cfg. > > BUG=501332 > [email protected] > > Committed: https://chromium.googlesource.com/external/webrtc/+/141725f50fa4223ce2f9e84500971a44d7720c03 [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501332 Review URL: https://codereview.webrtc.org/1190283003 Cr-Commit-Position: refs/heads/master@{#9476}
aisouard
pushed a commit
that referenced
this issue
Jul 16, 2015
…ttps:https://codereview.webrtc.org/1192673003/) Reason for revert: CQ-Rietveld combination now supports webrtc custom domain. Original issue's description: > Fix PRESUBMIT.py after disabling CQ. > > The disabling of CQ in https://codereview.webrtc.org/1177243003/ > broke PRESUBMIT.py since it's trying to read cq.cfg. > > BUG=501332 > [email protected] > > Committed: https://chromium.googlesource.com/external/webrtc/+/141725f50fa4223ce2f9e84500971a44d7720c03 [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501332 Review URL: https://codereview.webrtc.org/1190283003 Cr-Commit-Position: refs/heads/master@{#9476}
aisouard
pushed a commit
that referenced
this issue
Sep 4, 2015
… of https://codereview.webrtc.org/1290573004/ ) Reason for revert: A few bots started failing rtc_unittests after this was commited. Ex https://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5048 Original issue's description: > Use RtcpPacket to send REMB in RtcpSender > > BUG=webrtc:2450 > [email protected] > > Committed: https://chromium.googlesource.com/external/webrtc/+/35ab4baa20a730de71b390008900a16563cbbe8e [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:2450 Review URL: https://codereview.webrtc.org/1300863002 Cr-Commit-Position: refs/heads/master@{#9723}
aisouard
pushed a commit
that referenced
this issue
Sep 4, 2015
…hset #1 id:1 of https://codereview.webrtc.org/1287913004/ ) Reason for revert: (retrying with my webrtc account...) The reason for reverting is: Re-landing the change that removes the CpuMonitor class after having fixed the build issue in Chromium.. Original issue's description: > Revert "Remove CpuMonitor and related, unused, code." > > This reverts commit 1a24012. > > [email protected],[email protected] > BUG= > > This breaks > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux/builds/20148/steps/compile/logs/stdio > > Committed: https://chromium.googlesource.com/external/webrtc/+/a472e968c95fb14e63ec42f453551d0967573ea8 [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.webrtc.org/1290033005 Cr-Commit-Position: refs/heads/master@{#9733}
aisouard
pushed a commit
that referenced
this issue
Sep 4, 2015
… of https://codereview.webrtc.org/1300863002/ ) Reason for revert: This wasn't the cause of the breakage. Re-reverting. https://code.google.com/p/webrtc/issues/detail?id=4923 Original issue's description: > Revert of Use RtcpPacket to send REMB in RtcpSender (patchset #1 id:1 of https://codereview.webrtc.org/1290573004/ ) > > Reason for revert: > A few bots started failing rtc_unittests after this was commited. Ex https://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5048 > > Original issue's description: > > Use RtcpPacket to send REMB in RtcpSender > > > > BUG=webrtc:2450 > > [email protected] > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/35ab4baa20a730de71b390008900a16563cbbe8e > > [email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:2450 > > Committed: https://crrev.com/141c5951f4beda868797c2746002a4b1b267ab2a > Cr-Commit-Position: refs/heads/master@{#9723} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:2450 Review URL: https://codereview.webrtc.org/1309723002 Cr-Commit-Position: refs/heads/master@{#9754}
aisouard
pushed a commit
that referenced
this issue
Sep 4, 2015
…hset #1 id:1 of https://codereview.webrtc.org/1310953006/ ) Reason for revert: Both bots are now back online. Let's try enabling them again. Original issue's description: > Excluding two troublesome trybots from the CQ config. > > Temporary measurement to allow landing of a queue of CLs. > > BUG=524352, 526625 > [email protected] > > Committed: https://chromium.googlesource.com/external/webrtc/+/fa7cb8eaa72a33fd8d790674f98b35afbe9d863c [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524352, 526625 Review URL: https://codereview.webrtc.org/1305983005 Cr-Commit-Position: refs/heads/master@{#9842}
aisouard
pushed a commit
that referenced
this issue
Sep 15, 2015
…:https://codereview.webrtc.org/1313233005/ ) Reason for revert: It looks like this broke the FYI bots. I tried updating libjingle_nacl.gyp, but the IOS build still failed because in Chrome it's configured to use NSS. See https://codereview.chromium.org/1316863012/. Original issue's description: > purge nss files and dependencies > > BUG=webrtc:4497 > > Committed: https://crrev.com/5647a2cf3db888195c928a1259d98f72f6ecbc15 > Cr-Commit-Position: refs/heads/master@{#9862} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4497 Review URL: https://codereview.webrtc.org/1311843006 Cr-Commit-Position: refs/heads/master@{#9867}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are more than 3,000 files to build, the libwebrtc library only needs about 300 files because they've removed every dependencies to video and audio modules.
We should remove everything related to audio and video codecs.
Here's a list of every libraries compiled and needed by Peeracle, put a ☑️ when you've managed to remove a useless dependency.
The text was updated successfully, but these errors were encountered: