-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node version #2129
Upgrade node version #2129
Conversation
I think node v16 gives us a little more time to the next upgrade |
Which puppeteer version should we choose? What are the breaking changes that we should avoid? |
I think we should upgrade node-fetch to v2.6.9 (nice). We are in 2.6.5 so probably won't break a thing. https://github.com/node-fetch/node-fetch/releases/tag/v2.6.9 |
I wonder why the library supports old version |
Because the last version of ubuntu would install node v12 on apt install nodejs |
Sort of... v16 will be reaching EOL in 5 months |
Thanks for sharing this info and for working on this PR! ❤️ Relying on Ubuntu as the primary deployment method seems arbitrary, particularly since this is just one of the many ways one could deploy WWeb applications. Moreover, it appears we haven't documented this decision or provided any deployment guidance, which means only those who happen to be already deploying on Ubuntu would benefit from it. To exemplify: When I deployed my first app, I turned to Puppeteer's guides for recommended deployment steps. My deployment process still follows one of their guides. I wholeheartedly agree with the changes proposed in this PR. As a Node project, rather than an Ubuntu one, it's important that we adhere to Node's release schedule. Sticking to whatever is the |
If you test this PR please include your node version ( |
13 Puppetmaster has stopped working properly. Some files are not loading. With Puppeteer 18.2.1 files are loaded successfully. I will be switching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows 10
Node v18.17.1
Puppeteer v18.2.1
WWeb v2.2333.11
WWebJS v1.22.1
Tested some library functions, version caching and my opened PRs, works perfect
Warnings: Win7 only supports node 13 |
Well, we could always add a note about that 🤷 |
up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
Upgrade node version (pedroslopez#2129)
how to use this newly pushed code? |
PR Details
It's time to upgade the node version
Description
The latest ubuntu version, installs node v18. So we can upgrade node and the other dependencies
[https://packages.ubuntu.com/kinetic/nodejs]
Warnings
Win7 don't support node 18 ... (only up to 13)
Types of changes
TO DO
Tested
Windows. Node v18.16.0. WaWeb 2.2326.10. [2023-06-24]