Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition issue for cached package #2749

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.04%. Comparing base (f70e5b4) to head (6a9ab61).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2749      +/-   ##
==========================================
- Coverage   85.16%   85.04%   -0.13%     
==========================================
  Files         106      106              
  Lines       10548    10556       +8     
  Branches     2290     2293       +3     
==========================================
- Hits         8983     8977       -6     
- Misses       1094     1104      +10     
- Partials      471      475       +4     
Flag Coverage Δ
unittests 84.82% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 397d9b0 into main Mar 30, 2024
20 of 21 checks passed
@frostming frostming deleted the frostming/issue2739 branch March 30, 2024 10:39
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant