Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PDM installs wrong architecture of pywin32 wheel on Windows #2467

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #2464

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82a4574) 84.55% compared to head (cb071f9) 84.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2467      +/-   ##
==========================================
+ Coverage   84.55%   84.56%   +0.01%     
==========================================
  Files         104      104              
  Lines       10280    10290      +10     
  Branches     2247     2248       +1     
==========================================
+ Hits         8692     8702      +10     
  Misses       1114     1114              
  Partials      474      474              
Flag Coverage Δ
unittests 84.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 675f3ab into main Dec 7, 2023
21 checks passed
@frostming frostming deleted the frostming/issue2464 branch December 7, 2023 06:52
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDM installs wrong architecture of pywin32 wheel on Windows
1 participant