Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New lock strategy: inherit_metadata #2421

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d2057a5) 84.39% compared to head (3cf21b2) 84.36%.

Files Patch % Lines
src/pdm/models/repositories.py 63.63% 2 Missing and 2 partials ⚠️
src/pdm/cli/utils.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2421      +/-   ##
==========================================
- Coverage   84.39%   84.36%   -0.04%     
==========================================
  Files         104      104              
  Lines       10179    10215      +36     
  Branches     2226     2238      +12     
==========================================
+ Hits         8591     8618      +27     
- Misses       1114     1119       +5     
- Partials      474      478       +4     
Flag Coverage Δ
unittests 84.16% <90.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit b8bdaeb into dev Nov 23, 2023
20 of 21 checks passed
@frostming frostming deleted the feat/lock-inherit-metadata branch November 23, 2023 00:48
@sigma67
Copy link
Contributor

sigma67 commented Dec 5, 2023

@frostming I'm curious, are there any disadvantages to using the new, faster inherit_metadata strategy? I'm wondering why it is opt-in.

If so it should probably be mentioned in doc/changelog.

@frostming
Copy link
Collaborator Author

are there any disadvantages to using the new, faster inherit_metadata strategy?

Since it is a significant change in how installation finds packages, I am not sure it is 100% consistent with old behavior. But I also like this strategy and would like to use it as default in my packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants