Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export cross-platform requirements #2418

Merged
merged 2 commits into from
Nov 22, 2023
Merged

feat: export cross-platform requirements #2418

merged 2 commits into from
Nov 22, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (3d67092) 84.40% compared to head (b909158) 84.41%.
Report is 1 commits behind head on dev.

Files Patch % Lines
src/pdm/models/markers.py 80.26% 11 Missing and 4 partials ⚠️
src/pdm/resolver/graph.py 90.00% 4 Missing and 2 partials ⚠️
src/pdm/formats/pipfile.py 66.66% 1 Missing ⚠️
src/pdm/models/repositories.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2418      +/-   ##
==========================================
+ Coverage   84.40%   84.41%   +0.01%     
==========================================
  Files         102      104       +2     
  Lines       10131    10173      +42     
  Branches     2229     2226       -3     
==========================================
+ Hits         8551     8588      +37     
- Misses       1106     1111       +5     
  Partials      474      474              
Flag Coverage Δ
unittests 84.21% <87.63%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit 70df458 into dev Nov 22, 2023
21 checks passed
@frostming frostming deleted the feat/merge-markers branch November 22, 2023 02:11
@deronnax
Copy link
Sponsor Contributor

Hey, we actually appreciated (and used) the previous requirement (snyk does not understands platform markers). Would it be doable to add an option to export following the previous behavior?
Thank you.

@frostming
Copy link
Collaborator Author

(snyk does not understands platform markers)

That is quite surprising, does it mean it only understands the output of pip freeze?

@deronnax
Copy link
Sponsor Contributor

I think so. I re-did the test various time and I confirm snyk does not understand platform markers. I can provide use case if you want.

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants