Switch to yaml-cpp #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d PC_type, PC_document_line
jbigot
reviewed
Jun 1, 2021
| `some_map.yaml`: | ||
| ```yaml | ||
| key_1: value_1 | ||
| inner_sequence: !include "some_sequence.yaml" |
There was a problem hiding this comment.
do you support the !include syntax in paraconf or was it already in yaml-cpp?
paraconf/include/paraconf/PC_node.h
Outdated
| * | ||
| * \return postprocessed node | ||
| */ | ||
| PC_node postprocess_result(PC_node node) const; |
There was a problem hiding this comment.
I believe the include mechanism would better be implemented in a separate library
paraconf/src/PC_node.cxx
Outdated
| size_t PC_node::size() const | ||
| { | ||
| if (!m_node.IsDefined()) { | ||
| throw Error{PC_NODE_NOT_FOUND, "Cannot get size of not defined tree"}; |
There was a problem hiding this comment.
I wouldn't use defensive programing, just state it as a prerequisite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g_error_context)Should be tagged as
0.5.0