Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting filename when extracting embedded files #338

Merged
merged 3 commits into from
Jan 16, 2020

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Nov 17, 2019

Description

The File Specification dictionary (PDF reference 1.7, chapter 3.10.2) contains a string that represents a uniform resource allocator (key F). It optionally contains a unicode text string for the same URL (key UF).

Pdfminer.six prefers the UF key, but does not fall back properly on the F key when UF does not exist.

Fixes #152

How Has This Been Tested?

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the README.md and other documentation, or I am sure that this is not necessary
  • I have added a consice human-readable description of the change to CHANGELOG.md
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial version

@pombredanne
Copy link
Contributor

LGTM

@pietermarsman pietermarsman merged commit 2f7f5d2 into develop Jan 16, 2020
@pietermarsman pietermarsman deleted the filespec-filename branch January 21, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of filenames in file specifications
2 participants