Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repeatable options #524

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Update repeatable options #524

merged 1 commit into from
Feb 27, 2023

Conversation

mguidetti
Copy link
Contributor

@mguidetti mguidetti commented Dec 24, 2022

This pr adds --bypass-proxy-for and --replace as repeatable wkhtmltopdf options.

These options were previously missing and are documented as repeatable here

Fixes #523

@akimd
Copy link

akimd commented Dec 28, 2022

FWIW, LGTM.

@github-actions
Copy link

This pull request has been marked as stale and will be automatically closed.

@mguidetti
Copy link
Contributor Author

Hi @serene, any possibility of a merge here? Thank you!

@serene serene merged commit 2deebe3 into pdfkit:master Feb 27, 2023
@serene
Copy link
Contributor

serene commented Feb 27, 2023

I wonder why the build didn't run for this PR?
There is something wrong with the specs that need to be looked at before I can release the next version. See failing build here: #529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multiple replace
3 participants