Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow duplicate fieldNames to be used on the same level #4381

Merged
merged 10 commits into from
Dec 11, 2023

Conversation

JarrodMFlesch
Copy link
Contributor

@JarrodMFlesch JarrodMFlesch commented Dec 4, 2023

Description

Fixes #4337

FieldNames on the same level should be unique. This will now throw an error if the same field name is used multiple times on the same level, i.e. sibling fields including within rows and un-named tabs.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@JarrodMFlesch JarrodMFlesch changed the title chore: disallow duplicate fieldNames to be used on the same level fix: disallow duplicate fieldNames to be used on the same level Dec 4, 2023
@JarrodMFlesch JarrodMFlesch merged commit a1d66b8 into main Dec 11, 2023
29 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/duplicate-fieldName-error-handling branch December 11, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using 2 fields with same name, but rendered based on condition triggers infinite re-render
1 participant