Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hasMany number and select fields unable to save within arrays #4047

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix: hasMany number and select fields unable to save within arrays #4047

merged 2 commits into from
Nov 8, 2023

Conversation

JarrodMFlesch
Copy link
Contributor

@JarrodMFlesch JarrodMFlesch commented Nov 8, 2023 •
edited
Loading

Description

  • I have read and understand the CONTRIBUTING.md document in this repository.

Fixes #3983

  • hasMany number fields within arrays were not creating a top level table to store them in
  • corrects hasMany select fields not storing parentIDs

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@JarrodMFlesch JarrodMFlesch merged commit 182c57b into main Nov 8, 2023
25 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/nested-array-db-pg branch November 8, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denolfe denolfe Awaiting requested review from denolfe

@jmikrut jmikrut Awaiting requested review from jmikrut

@DanRibbens DanRibbens Awaiting requested review from DanRibbens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Foreign key error when adding tenant to user in the multi tenant example
1 participant
@JarrodMFlesch