Skip to content

Commit

Permalink
chore: temporarily disable deprecation warnings (denoland#22204)
Browse files Browse the repository at this point in the history
  • Loading branch information
bartlomieju authored Jan 31, 2024
1 parent 95e4741 commit fddbb01
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 28 deletions.
4 changes: 3 additions & 1 deletion cli/factory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,9 @@ impl CliFactory {
self.feature_checker().clone(),
self.create_cli_main_worker_options()?,
self.options.node_ipc_fd(),
self.options.disable_deprecated_api_warning,
// TODO(bartlomieju): temporarily disabled
// self.options.disable_deprecated_api_warning,
true,
self.options.verbose_deprecated_api_warning,
))
}
Expand Down
4 changes: 3 additions & 1 deletion cli/standalone/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,9 @@ pub async fn run(
maybe_root_package_json_deps: package_json_deps_provider.deps().cloned(),
},
None,
metadata.disable_deprecated_api_warning,
// TODO(bartlomieju): temporarily disabled
// metadata.disable_deprecated_api_warning,
true,
false,
);

Expand Down
53 changes: 27 additions & 26 deletions cli/tests/integration/run_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5216,35 +5216,36 @@ itest!(unstable_temporal_api_missing_flag {
exit_code: 1,
});

itest!(warn_on_deprecated_api {
args: "run -A run/warn_on_deprecated_api/main.js",
output: "run/warn_on_deprecated_api/main.out",
http_server: true,
exit_code: 0,
});
// TODO(bartlomieju): temporary disabled
// itest!(warn_on_deprecated_api {
// args: "run -A run/warn_on_deprecated_api/main.js",
// output: "run/warn_on_deprecated_api/main.out",
// http_server: true,
// exit_code: 0,
// });

itest!(warn_on_deprecated_api_verbose {
args: "run -A run/warn_on_deprecated_api/main.js",
output: "run/warn_on_deprecated_api/main.verbose.out",
envs: vec![("DENO_VERBOSE_WARNINGS".to_string(), "1".to_string())],
http_server: true,
exit_code: 0,
});
// itest!(warn_on_deprecated_api_verbose {
// args: "run -A run/warn_on_deprecated_api/main.js",
// output: "run/warn_on_deprecated_api/main.verbose.out",
// envs: vec![("DENO_VERBOSE_WARNINGS".to_string(), "1".to_string())],
// http_server: true,
// exit_code: 0,
// });

itest!(warn_on_deprecated_api_with_flag {
args: "run -A --quiet run/warn_on_deprecated_api/main.js",
output: "run/warn_on_deprecated_api/main_disabled_flag.out",
http_server: true,
exit_code: 0,
});
// itest!(warn_on_deprecated_api_with_flag {
// args: "run -A --quiet run/warn_on_deprecated_api/main.js",
// output: "run/warn_on_deprecated_api/main_disabled_flag.out",
// http_server: true,
// exit_code: 0,
// });

itest!(warn_on_deprecated_api_with_env_var {
args: "run -A run/warn_on_deprecated_api/main.js",
envs: vec![("DENO_NO_DEPRECATION_WARNINGS".to_string(), "1".to_string())],
output: "run/warn_on_deprecated_api/main_disabled_env.out",
http_server: true,
exit_code: 0,
});
// itest!(warn_on_deprecated_api_with_env_var {
// args: "run -A run/warn_on_deprecated_api/main.js",
// envs: vec![("DENO_NO_DEPRECATION_WARNINGS".to_string(), "1".to_string())],
// output: "run/warn_on_deprecated_api/main_disabled_env.out",
// http_server: true,
// exit_code: 0,
// });

#[test]
fn deno_json_imports_expand() {
Expand Down

0 comments on commit fddbb01

Please sign in to comment.