Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for (gitlab) config #99

Merged
merged 2 commits into from
Dec 1, 2017
Merged

update readme for (gitlab) config #99

merged 2 commits into from
Dec 1, 2017

Conversation

paulirish
Copy link
Owner

this is docs for #92

@paulirish
Copy link
Owner Author

@derimagia i didn't really expect "https://" to be in the config name, since that isn't part of the actual git repo URL. is it just a concession to keep the implementation simple?

if possible seems like it wouldn't be part of the config name. wdyt?

@paulirish paulirish added this to the 2.0 milestone Oct 27, 2017
@derimagia
Copy link
Collaborator

@paulirish I did that so we could take advantage of https://git-scm.com/docs/git-config#git-config---get-urlmatchnameURL (so I think you could even use it to do all subdomains as well?).

I'm not too attached to it and am fine with changing it - it just looked like a good fit

@derimagia
Copy link
Collaborator

It looks like it also works with paths, so you can have it so that https://github.com/paulirish goes to one path but https://github.com and any other path goes to another one.

I'd also mention in the readme that you can do --global. It looks like --local is the default for writing, so I think the way it was before is a little better (git config [--global]). Looks like --add isn't needed (I may have had it in the test, but looks like the default is "to replace at most one line").

@derimagia
Copy link
Collaborator

Had the idea as well that we could take care of a lot of requests with this by also adding a setting for "open.branch" to override the branch like we do with protocol/server

README.md Outdated
git config [--global] gitopen.gitlab.ssh.port [value]
```
<!--
git config --local --add open.[gitdomain].domain [value]
Copy link
Collaborator

@derimagia derimagia Oct 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like --local is the default for writing, so I think the way it was before is a little better (git config [--global]). Looks like --add isn't needed (I may have had it in the test, but looks like the default is "to replace at most one line").

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya sgtm on dropping --local and --add. i also was headscratching on what value they added. :)

@paulirish
Copy link
Owner Author

@derimagia

I did that so we could take advantage of git-scm.com/docs/git-config#git-config---get-urlmatchnameURL (so I think you could even use it to do all subdomains as well?).

I'm not too attached to it and am fine with changing it - it just looked like a good fit

im ok with it, but it's just something we'll have to explain to the user, as its a bit counterintuitive.

do you wanna take a swipe at updating these docs? I think you can speak to it a little better than me. :)

@paulirish
Copy link
Owner Author

Alright I made the basic change here of --local --add ==> [--global].

I left the https:// prefix the same. I think it probably need some additional explanation at some point, but I don't want to hold up the docs on it right now.

It looks like it also works with paths

This is also something we could document if it comes up.

Had the idea as well that we could take care of a lot of requests with this by also adding a setting for "open.branch" to override the branch like we do with protocol/server

Seems interesting. If anyone is fond of the idea plz feel free to open an issue so we can explore it a bit more.

@paulirish paulirish merged commit f0bcdd2 into master Dec 1, 2017
@paulirish paulirish deleted the configreadme branch December 1, 2017 21:41
iblea pushed a commit to iblea/git-open that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants