allow command to be run in git repo subdirectory #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm Nitpick would be if you could use 'Yes' or 1 instead that's what it looks like it does here: https://github.com/git/git/search?utf8=%E2%9C%93&q=SUBDIRECTORY_OK&type= They also have "Sometimes" in one or two places, I wonder if that's used for anything Also you should also be able to put it on the same line as the source if you wanted to to make it clear it's used for the file |
|
perfect. done and done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the new
git-sh-setuprequires the command is run from the top of the working tree. :/reading the gh-sh-setup source, the fix seems to be just adding this env variable:
https://github.com/git/git/blob/1a4e40aa5dc16564af879142ba9dfbbb88d1e5ff/git-sh-setup.sh#L368