Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing gitlab tests #87

Closed
paulirish opened this issue Jun 21, 2017 · 2 comments · Fixed by #92
Closed

Failing gitlab tests #87

paulirish opened this issue Jun 21, 2017 · 2 comments · Fixed by #92

Comments

@paulirish
Copy link
Owner

We have two failing tests after the rewrite has landed

 ✗ gitlab: separate domains
   (from function `assert_output' in file test/test_helper/bats-assert/src/assert.bash, line 239,
    in test file test/git-open.bats, line 186)
     `assert_output "https://gitlab.example.com/namespace/project"' failed
   fatal: remote origin already exists.
   Switched to a new branch 'master'

   -- output differs --
   expected : https://gitlab.example.com/namespace/project
   actual   : https://git.example.com/namespace/project
 ✗ gitlab: ssh:https://git@host:port origin
   (from function `assert_output' in file test/test_helper/bats-assert/src/assert.bash, line 239,
    in test file test/git-open.bats, line 220)
     `assert_output "https://repo.intranet/XXX/YYY"' failed
   fatal: remote origin already exists.
   Switched to a new branch 'master'

   -- output differs --
   expected : https://repo.intranet/XXX/YYY
   actual   : https://repo.intranet/7000/XXX/YYY
   --

@derimagia how did you want to handle these guys?

@ffes
Copy link
Collaborator

ffes commented Jun 21, 2017

I think reuse the old implementation a bit. I will look at it this weekend unless someone beats me 😉

@paulirish
Copy link
Owner Author

K. I'm skipping those tests for now to make the build green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants