Parse datetimes/timestamps with fractional seconds. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not against a CPP conditional, if you want to modify your change to use one. I do want to support Stackage 2,X for a while longer, to allow ghc 7.8, but I will consider removing it once ghc 8.2.X is out, and the conditional can be removed at that time. |
|
Well, that was just an aside since I happened to notice the deprecation. The important part is adding the "%Q" to the format so timestamps with fractional seconds don't return parse errors. Everything else can be a separate issue.
|
|
Fair enough. I'll merge it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.,
timestamp(3)returns an error.