Pattern param rework #771

bmuenzenmeyer · 2018-01-15T18:17:35Z

Addresses #769 Rework Pattern Parameter Algorithm

Summary of changes:

Found pattern parameters are no longer rendered immediately. Not sure why I ever thought that was a good idea. Now, they are evaluated and replace their value or section in the pattern's extendedTemplate
All tests are passing - excepting two which I commented out.
I expect that list_item_hunter should be similarly refactored.

…ttle

…good idea.

…o look for escaped values

coveralls · 2018-01-15T18:20:15Z

Coverage increased (+7.4%) to 71.349% when pulling 2f84d9c on pattern-param-rework into 578a9af on dev.

bmuenzenmeyer and others added 19 commits January 12, 2018 06:13

checking in some sloppy wip

672ea88

chore(logs): Clean up logs a bit

3fe17e5

refactor(processRecursive): Use getPartial

c706267

refactor(expandPartials): Use getPartial

1021702

refactor(get): Remove path normalize call

be3b3f7

refactor(parameter_hunter): replaceParameter helper. may still be bri…

d486abf

…ttle

chore(lint): Fix lint issues

6ea5eee

fix(parameter_hunter): Replace algorithm

f0be039

fix(unit tests): change verbose partial paths. not sure if this is a …

6fe9785

…good idea.

fix(package): Remove unneeded dependency

438c6b1

refactor(unit tests): Commit WIP pattern parameter tests

e9d6c9e

feat(patternlab): Accept additional data during build as an option

3100402

chore(unit tests): WIP tests

5cc8703

fix(unit tests): Fix more tests

9f3c4c9

chore(unit tests): WIP

4072b61

fix(unit tests): Fix more tests. Since we no longer render, no need t…

c50484d

…o look for escaped values

fix(replaceParameter): Support unescaped replacement

019c6c4

chore(unit tests): Test WIP and lint fixes

13dbeaa

fix(parameter_hunter): Consume styleModifiers again

2f84d9c

bmuenzenmeyer self-assigned this Jan 15, 2018

bmuenzenmeyer merged commit 63117e2 into dev Jan 15, 2018

bmuenzenmeyer deleted the pattern-param-rework branch January 15, 2018 18:20

Provide feedback