Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Multiple pattern parameters down a render tree cause issues #663

Merged
merged 2 commits into from
May 19, 2017

Conversation

bmuenzenmeyer
Copy link
Member

part of resolution for pattern-lab/starterkit-mustache-acidtest#1

Addresses #539

Summary of changes:

  • Found pattern parameters retrieve the partial, of course, but that returned partial itself needs to check for pattern parameters.
  • I think now Node functionality is more on spec of individual patterns being independentally rendered, downstream.

@bmuenzenmeyer bmuenzenmeyer changed the title failing unit test demonstrating behavior in #539 FIX: Multiple pattern parameters down a render tree cause issues May 19, 2017
@coveralls
Copy link

coveralls commented May 19, 2017

Coverage Status

Coverage increased (+0.01%) to 71.511% when pulling 5998c9c on issue/539-chained-parameters into 1f456d2 on dev.

@coveralls
Copy link

coveralls commented May 19, 2017

Coverage Status

Coverage increased (+0.01%) to 71.511% when pulling 5998c9c on issue/539-chained-parameters into 1f456d2 on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit 4d99363 into dev May 19, 2017
@bmuenzenmeyer bmuenzenmeyer deleted the issue/539-chained-parameters branch May 19, 2017 06:25
bmuenzenmeyer referenced this pull request May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants