Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to nx workspace #1483

Draft
wants to merge 21 commits into
base: dev
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: view all pages
  • Loading branch information
JosefBredereck committed Feb 26, 2023
commit f21a8b0b1f76b6e5e6597672bbe1c04d236b671c
7 changes: 6 additions & 1 deletion packages/engine-handlebars/src/lib/engine-handlebars.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ export class EngineHandlebars implements PatternLabEngine {
engineFileExtension = ['.hbs', '.handlebars'];
expandPartials = false;

renderPattern(pattern: Pattern, data: PatternData): Promise<string> {
// TODO: partials via the render pattern is a bit hacky
renderPattern(pattern: Pattern, data: PatternData, partials?: any): Promise<string> {
if (partials) {
this.engine.registerPartial(partials);
}

const compiled = this.engine.compile(this.escapeAtPartialBlock(pattern.template));

return Promise.resolve(compiled(data));
Expand Down
5 changes: 3 additions & 2 deletions packages/engine-mustache/src/lib/engine-mustache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ export class EngineMustache implements PatternLabEngine {
engineFileExtension = ['.mustache'];
expandPartials = true;

renderPattern(pattern: Pattern, data: PatternData): Promise<string> {
// TODO: partials via the render pattern is a bit hacky
renderPattern(pattern: Pattern, data: PatternData, partials?: any): Promise<string> {
try {
return Promise.resolve(this.engine.render(pattern.extendedTemplate, data));
return Promise.resolve(this.engine.render(pattern.extendedTemplate, data, partials));
} catch (e) {
console.log('e = ', e);
return Promise.reject(e);
Expand Down