Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styleModifiers are not included in pseudo patterns #474

Closed
gael-boyenval opened this issue Sep 19, 2016 · 5 comments · Fixed by #476
Closed

styleModifiers are not included in pseudo patterns #474

gael-boyenval opened this issue Sep 19, 2016 · 5 comments · Fixed by #476

Comments

@gael-boyenval
Copy link
Contributor

I am using Pattern Lab Node v2.5.0 on Mac, with Node v6+, using the Gulp Edition.

Expected Behavior

for a given pattern X and his pseudo pattern :

patternX:

<h2>{{ data }}</h2>
{{> patternY:modifier--foo }}

patternX~pseudo.json:

{ data: "yyy" }

this should output the included pattern Y with the style modifier
patternX-pseudo html output :

<h2> yyy </h2>
<div class="patternY modifier--foo">
       bar
</div>
Actual Behavior

The styleModifier is not included :

<h2> yyy </h2>
<div class="patternY">
       bar
</div>
@bmuenzenmeyer bmuenzenmeyer self-assigned this Sep 21, 2016
@bmuenzenmeyer
Copy link
Member

@gael-boyenval in your above breakdown, patternY.mustache looks like this correct?

<div class="patternY {{styleModifier}}">
  bar
</div>

@bmuenzenmeyer
Copy link
Member

confirmed bug.

image

@bmuenzenmeyer
Copy link
Member

pseudomodifier474.zip

test files

@bmuenzenmeyer bmuenzenmeyer modified the milestone: 2.6.0 Sep 22, 2016
@gael-boyenval
Copy link
Contributor Author

@bmuenzenmeyer : yes exactly !

bmuenzenmeyer added a commit that referenced this issue Sep 22, 2016
copy found partials when processing pseudo-patterns
@bmuenzenmeyer
Copy link
Member

@gael-boyenval this will be fixed with the next version release. !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants