Fix issue with updating traps #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an "array to string" conversion problem for traps that are already present in the database. The issue I've come across that this fixes is that instead of passing an entire array, it now passes just the ID's to make the query work instead of aborting the process. On the next run without this fix, it thinks the trap is already imported and skips it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an "array to string" conversion problem for traps that are already present in the database. Usually seen as "Error in update : Array to string conversion", with an aborted import / update of mibs as a result.
The issue I've come across that this fixes is that instead of passing an entire array to the ":id", it now passes just the ID's to make the query work instead of aborting the process.
On the next run regardless of this fix, the code thinks the trap is already imported if it has already been attempted to be imported before and skips it. This ticket does not fix that issue.