Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in stable_distribute function. #27

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

asrivast28
Copy link
Contributor

Problem: The mxx::stable_distribute function calls mxx::all2allv by dereferencing the begin input iterator. This may lead to undefined behavior (possibly segfault) if the iterator is for an empty container, since begin will be the same as end iterator in such cases.
Solution: Only dereference iterators that are guaranteed to point to allocated addresses.

Only dereference iterators that are guaranteed to point to an allocated address.
@patflick patflick merged commit 435e04d into patflick:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants