Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameters in datatypes and env #22

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Remove unused parameters in datatypes and env #22

merged 1 commit into from
Feb 12, 2020

Conversation

mquevill
Copy link
Contributor

These changes remedy gcc warnings of unused parameters, mainly for debug builds.

In datatype_name(), the variable o seems like just a place holder. In my_mpi_errorhandler(), the variable comm is commented out, to keep the variable documented.

All tests pass with these changes.

Copy link
Owner

@patflick patflick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@patflick patflick merged commit 153b2c3 into patflick:master Feb 12, 2020
@mquevill mquevill deleted the unused_param branch February 12, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants