Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 8 #503

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Update to .NET 8 #503

merged 2 commits into from
Feb 28, 2024

Conversation

joegoldman2
Copy link
Contributor

Fixes #419.
Fixes #497.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b597d18) 74.44% compared to head (4a34cc8) 74.45%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   74.44%   74.45%           
=======================================
  Files          99       98    -1     
  Lines        2677     2666   -11     
  Branches      455      445   -10     
=======================================
- Hits         1993     1985    -8     
+ Misses        580      578    -2     
+ Partials      104      103    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fair (just holding off merging for a bit)

@abergs
Copy link
Collaborator

abergs commented Feb 16, 2024

@iamcarbon Since you've been prepping for .net 8, please feel free to do a review. If no comments I'll bring this.

Thanks for the contribution @joegoldman2

@iamcarbon
Copy link
Sponsor Contributor

Looks good here! Thanks @joegoldman2

This also enables us to use frozen collections, collection builders, init only members (that can remain serializable by System.Text.Json), required properties, and some other nice things from .NET 8.0.

@abergs abergs merged commit 0f302e2 into passwordless-lib:master Feb 28, 2024
11 checks passed
@joegoldman2 joegoldman2 deleted the fix/419 branch February 28, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community Feedback on requiring .NET8.0 for v4 release Cross Target .NET8.0
4 participants