Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add many unit tests for nearly all attestation types #162

Merged
merged 13 commits into from
May 15, 2020
Merged

Add many unit tests for nearly all attestation types #162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4cf3fab
Adding some work in progress attestation tests
aseigler Feb 25, 2020
02eb039
More WIP
aseigler Feb 29, 2020
cfaa719
U2F tests nearly complete
aseigler Feb 29, 2020
86cb26f
WIP
aseigler Mar 29, 2020
5e70ca5
EC2 tests for TPM are working
aseigler Apr 9, 2020
bd3b1c6
TPM positive cases working for both EC2 and RSA
aseigler Apr 10, 2020
47cbffe
Added a bunch of packed and TPM tests, added a little bit more error …
aseigler May 9, 2020
19c626e
Remainder of TPM tests (except chain validation).
aseigler May 11, 2020
92b03ff
Add (nearly complete) AndroidKey tests.
aseigler May 13, 2020
028ca0b
Update an Android Key test to StartsWith instead of Equal
aseigler May 13, 2020
1ff9c7b
Fix test data file name capitalization
aseigler May 15, 2020
3407c57
Change tests to use async properly
aseigler May 15, 2020
8fc05e2
Try to prevent test hangs
aseigler May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Remainder of TPM tests (except chain validation).
  • Loading branch information
@aseigler
aseigler committed May 11, 2020
commit 19c626e01357eea16765bb74418cc8da850cc4b6
4 changes: 2 additions & 2 deletions Src/Fido2/AttestationFormat/Tpm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ public override void Verify()
certInfo = new CertInfo(attStmt["certInfo"].GetByteString());
}

if (null == certInfo || null == certInfo.ExtraData || 0 == certInfo.ExtraData.Length)
if (null == certInfo)
throw new Fido2VerificationException("CertInfo invalid parsing TPM format attStmt");

// Verify that magic is set to TPM_GENERATED_VALUE and type is set to TPM_ST_ATTEST_CERTIFY
Expand Down Expand Up @@ -580,7 +580,7 @@ public override void Verify()
// OID is 2.23.133.8.3
var EKU = EKUFromAttnCertExts(aikCert.Extensions, "2.23.133.8.3");
if (!EKU)
throw new Fido2VerificationException("Invalid EKU on AIK certificate");
throw new Fido2VerificationException("aikCert EKU missing tcg-kp-AIKCertificate OID");

// The Basic Constraints extension MUST have the CA component set to false.
if (IsAttnCertCACert(aikCert.Extensions))
Expand Down