Upgrading project to remove EOL frameworks #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abergs The pipeline step that's breaking is explicitly trying to build in .netcore framework 2.2 (this will always break since this PR is removing that). |
|
That makes a ton of sense. Do you know when something like this will happen? We are wanting to start using this in .net 3.1 as soon as we can |
|
What would you recommend in regards to the timeline? Should we fork and attempt a merge in the future? |
|
Done in #145. Are there any other changes you want to make? |
|
Nope! thank you for doing this. I will try to pull the latest and incorporate them in. If I run into anything else, ill submit a fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the application to .net core 3.1 based on the guidelines defined here
This updates the libraries to .netstandard 2.1 but maintains .netstandard 2.0 for those using this library with .netcoreapp 2.1
this will also rev the version from 1.0.1 to 1.0.2 to indicate a patch increment (even though the framework was updated) as the package is still backwards compatible and no new features have been added