Only include dist folder in package #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnelies
added a commit
that referenced
this pull request
Nov 21, 2022
This reverts commit 65075d2.
|
Oops ...that was a mistake from me ...without sources it will break the source maps :/ ...I'll put them back later |
dagnelies
added a commit
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting the package in issue #8 I noticed the
demosfolder is also being included in the package which I didn't think was intentional.Given the
distfolder has all the code, sourcemaps, and types, it should be sufficient as is. Including the demos bloats the size of the package and changes to the demos shouldn't affect the package.