Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support browser extensions #46

Closed

Conversation

raynirola
Copy link

@raynirola raynirola commented Apr 14, 2024

This PR adds support for browser extensions. No breaking change, optional mode parameter set to browser by default. Fixes #45

@dagnelies
Copy link
Collaborator

That looks quite odd and seem to differ from what the specs says. But it would not be the first time that reality differs from the specs. 🙄

That said, I'd rather allow people to customize/override rp.id/name instead. It's more intuitive, simpler to understand and would also solve the subdomains and iframes use cases.

@dagnelies
Copy link
Collaborator

Solved here instead: 1c005db

You can now override rp:{id:..., name:...} in the registration options

@dagnelies dagnelies closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected RpIdHash
2 participants