This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
Add initial offset #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent prior to the first commit
Read the streams from both external commands that use "waitFor()" to prevent the buffers from completely filling and the process blocking until it is read.
The stream is read with def featurelines = diffToDefault.text.trim().readLines() - which will crash if stream read sooner
passsy
reviewed
Sep 24, 2018
| @@ -69,6 +69,7 @@ ext.gitVersioner = [ | |||
| yearFactor : 1200, // default "1000", increasing every 8.57h | |||
| snapshotEnabled : false, // default false, the "-SNAPSHOT" postfix | |||
| localChangesCountEnabled: false, // default false, the (<commitCount>) before -SNAPSHOT | |||
| initialOffset : 2100000, // default "0", amount of time (in seconds) to offset the initial commit by, if development started before commits began | |||
There was a problem hiding this comment.
Wouldn't it be better to set an exact timestamp instead of a difference compared to the first commit?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial offset to commit time calculations, to allow for development prior to the first commit.