fix: Parse Server option maxLogFiles doesn't recognize day duration literals such as 1d to mean 1 day
#9215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9215 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 186 186
Lines 14762 14766 +4
=======================================
+ Hits 13797 13801 +4
Misses 965 965 ☔ View full report in Codecov by Sentry. |
|
Note: before merging this, merge #9205 so that it creates a release with test IDs. |
mtrezza
changed the title
maxLogFiles doesn't accept days stringmaxLogFiles doesn't accept days string
mtrezza
changed the title
maxLogFiles doesn't accept days stringmaxLogFiles doesn't recognize duration literals like 1d for 1 day
mtrezza
changed the title
maxLogFiles doesn't recognize duration literals like 1d for 1 daymaxLogFiles doesn't recognize duration literals like 1d for "1 day"
mtrezza
changed the title
maxLogFiles doesn't recognize duration literals like 1d for "1 day"maxLogFiles doesn't recognize day duration literal like 1d for "1 day"
mtrezza
changed the title
maxLogFiles doesn't recognize day duration literal like 1d for "1 day"maxLogFiles doesn't recognize day duration literals such as 1d to mean 1 day
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 18, 2024
# [7.3.0-alpha.5](7.3.0-alpha.4...7.3.0-alpha.5) (2024-07-18) ### Bug Fixes * Parse Server option `maxLogFiles` doesn't recognize day duration literals such as `1d` to mean 1 day ([#9215](#9215)) ([0319cee](0319cee))
|
🎉 This change has been released in version 7.3.0-alpha.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
The
maxLogFilesoption uses an objectParser which fails when entering a string.Closes: #6426
Approach
Add new Parser Type and Build Definition