Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git to Dockerfile #5861

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Add git to Dockerfile #5861

merged 1 commit into from
Jul 28, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 28, 2019

The push adapter now uses a node-apn fork. This PR adds git to the build to pull the fork down.

I'm not a docker expert. Any feedback would be great.

Screen Shot 2019-07-28 at 3 04 34 PM

@dplewis dplewis requested a review from TomWFox July 28, 2019 20:08
@TomWFox
Copy link
Contributor

TomWFox commented Jul 28, 2019

I have no idea about docker, so I really don't feel qualified to review this. @davimacedo could you take a look?

@dplewis
Copy link
Member Author

dplewis commented Jul 28, 2019

@TomWFox If you look at the file there are 2 build phases. The first build phase adds git, I just copied it down to the release build.

@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #5861 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5861      +/-   ##
=========================================
- Coverage   93.68%   93.1%   -0.59%     
=========================================
  Files         150     150              
  Lines       10616   10616              
=========================================
- Hits         9946    9884      -62     
- Misses        670     732      +62
Impacted Files Coverage Δ
...dapters/Cache/RedisCacheAdapter/KeyPromiseQueue.js 0% <0%> (-95.46%) ⬇️
src/Adapters/Cache/RedisCacheAdapter/index.js 15.9% <0%> (-84.1%) ⬇️
src/Controllers/LoggerController.js 90.52% <0%> (-1.06%) ⬇️
src/RestWrite.js 93.56% <0%> (-0.34%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.82% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80bb2b6...9acf7ab. Read the comment docs.

@TomWFox
Copy link
Contributor

TomWFox commented Jul 28, 2019

Ok, makes sense.

@dplewis dplewis merged commit f1619e4 into master Jul 28, 2019
@dplewis dplewis deleted the dplewis-patch-1 branch July 28, 2019 21:52
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@cbaker6 cbaker6 mentioned this pull request May 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants