Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64 0.21 #87

Merged
merged 2 commits into from
Feb 2, 2024
Merged

base64 0.21 #87

merged 2 commits into from
Feb 2, 2024

Conversation

kayabaNerve
Copy link
Contributor

encode_config_slice panicked if the slice was too short. It now returns an error. The added unwraps maintain the prior API.

src/handshake.rs Outdated Show resolved Hide resolved
src/handshake/client.rs Outdated Show resolved Hide resolved
@kayabaNerve
Copy link
Contributor Author

Sorry if this fell through the cracks, yet I did respond to your comments @niklasad1 👍

Copy link

@tadeohepperle tadeohepperle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@niklasad1
Copy link
Member

@kayabaNerve

Thanks, sorry I missed it as well but looks good

@niklasad1 niklasad1 merged commit 26a2fc6 into paritytech:master Feb 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants