Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCR set stubbed response handler fix. #5

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Conversation

parfeon
Copy link
Owner

@parfeon parfeon commented Jul 31, 2018

When cassette is playing, there is step of response setting. setResponse in NSURLSessionTask not get called for certain responses (those, for which Content-Type is something other than application/json).
With this fix, response setting handler has been moved from NSURLSessionTask to NSURLSessionConnection.

@parfeon parfeon added the bug Something isn't working label Jul 31, 2018
@parfeon parfeon self-assigned this Jul 31, 2018
@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #5 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   97.82%   97.82%   +<.01%     
==========================================
  Files          40       40              
  Lines        3488     3492       +4     
==========================================
+ Hits         3412     3416       +4     
  Misses         76       76
Impacted Files Coverage Δ
...sc/Categories/NSURLSessionConnection+YHVRecorder.m 100% <100%> (ø) ⬆️
...VCR/Misc/Categories/NSURLSessionTask+YHVRecorder.m 90% <100%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104cdc2...df0ae00. Read the comment docs.

@parfeon parfeon merged commit e93d7fd into master Jul 31, 2018
@parfeon parfeon deleted the fix-set-response branch July 31, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants