N950 and N9 ports #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2018
|
Looks good to me. @parazyd ? |
parazyd
reviewed
Apr 20, 2018
boards/nokia-n950.sh
Outdated
| notice "applying patches from patchwork" | ||
| cp $R/extra/pwclient/.pwclientrc ~ | ||
| $pwclient git-am -p linux-omap $patchids | ||
|
|
There was a problem hiding this comment.
We might want to remove .pwclientrc from $HOME after using it. Or see if there is an environment variable we can use to point it to extra/ where it already is.
There was a problem hiding this comment.
I looked for a parameter but couldn't find one. I'll check to see if it supports an environment variable and update it, otherwise I'll just remove it as you suggest.
There was a problem hiding this comment.
Will remove pwclient completely as agreed on IRC in order to avoid an additional remote dependency.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on merging of maemo-leste-upstream-forks/xorg-server#1 and maemo-leste/hildon-meta#1.