Fix ShadingPattern issues + eslint #3468
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs fixed
Patterns was unable to work with all functions who usefillWithPattern
.I rollback on that but
fillWithPattern
should take pattern key or pattern object in parameter and notpatternData
. All datas are already in patterns.fillWithPattern
function was writing matrix every time for shading patterns but the parameter is optional.Tested with below code
Result