Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inefficient Regular Expression for setZoomMode #3366

Closed
wants to merge 1 commit into from
Closed

Fix Inefficient Regular Expression for setZoomMode #3366

wants to merge 1 commit into from

Conversation

yetingli
Copy link
Contributor

Fix Inefficient Regular Expression for setZoomMode

Add test case for setZoomMode

Fix Inefficient Regular Expression for setZoomMode

Add test case for setZoomMode
@HackbrettXXX
Copy link
Collaborator

The new test case fails:

FAILED TESTS:
  Core: Unit Tests
    ✖ jsPDF private function setZoomMode, getZoomMode
      IE 11.0 (Windows 10)
      Chrome 94.0.4606.54 (Windows 10)
      Firefox 77.0 (Windows 10)
    Expected function to throw an exception.
    <Jasmine>
    @test/specs/jspdf.unit.spec.js:799:8
    <Jasmine>

@yetingli
Copy link
Contributor Author

The new test case fails:

FAILED TESTS:
  Core: Unit Tests
    ✖ jsPDF private function setZoomMode, getZoomMode
      IE 11.0 (Windows 10)
      Chrome 94.0.4606.54 (Windows 10)
      Firefox 77.0 (Windows 10)
    Expected function to throw an exception.
    <Jasmine>
    @test/specs/jspdf.unit.spec.js:799:8
    <Jasmine>

Thanks a lot! Can I delete the new test case directly?

@HackbrettXXX
Copy link
Collaborator

Yes, deleting the test case is OK.

@yetingli
Copy link
Contributor Author

Please see #3368. Thanks a lot!

@yetingli yetingli closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants