Fix margins type of TableConfig #3351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.margins in TableConfig takes Object with margin values for left, top, bottom, and width http:https://raw.githack.com/MrRio/jsPDF/master/docs/module-cell.html#~table
HackbrettXXX
requested changes
Jan 18, 2022
types/index.d.ts
Outdated
| @@ -607,7 +607,7 @@ declare module "jspdf" { | |||
| export interface TableConfig { | |||
| printHeaders?: boolean; | |||
| autoSize?: boolean; | |||
| margins?: number; | |||
| margins?: : {top?: number, left?: number, width?: number, bottom?: number}; | |||
There was a problem hiding this comment.
Thanks for the PR. I think width should be right.
EstebanFuentealba
added a commit
to EstebanFuentealba/jsPDF
that referenced
this pull request
Apr 5, 2022
config.margins in TableConfig takes Object with margin values for left, top, right, and bottom (modified parallax#3351) http:https://raw.githack.com/MrRio/jsPDF/master/docs/module-cell.html#~table
Add "right" to mergins in TableConfig interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.margins in TableConfig takes Object with margin values for left, top, bottom, and width
http:https://raw.githack.com/MrRio/jsPDF/master/docs/module-cell.html#~table
Thanks for contributing to jsPDF! Please follow our
Contribution Guidelines
when creating a pull request.