Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse data to string if cell value number #2875

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skchawala
Copy link

when the value is a number column is coming empty ( this PR #2872 could not fix it entirely which fixed this issue #2849 ).

for example in this setting coin value to a number is making the col empty.
Screenshot 2020-08-26 at 12 26 13 PM

so in this PR parsing data. user can turn it off if want or all data cell values are string /array of string.
by passing config.cellValueStringOnly to table function

Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should introduce a new option for this. Could you analyze where exactly the numbers are lost and fix it there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants