Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nodejs Build #2622

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Fix Nodejs Build #2622

merged 3 commits into from
Feb 6, 2020

Conversation

sedenardi
Copy link

This fixes the build process for Node.js targets by passing in the relevant global context (browser: 'window', node: 'global') to the rawjs plugin.

This addresses #1891, #2248, and #2491.

@laclance
Copy link

any idea on when this will be merged ?

@sedenardi
Copy link
Author

@laclance There hasn't been any activity on this library in over 2 months, as #2611 notes, so I wouldn't get your hopes up.

@robzen
Copy link

robzen commented Jan 1, 2020

please merge this.

@gsaandy
Copy link

gsaandy commented Jan 16, 2020

is there something blocking this to be merged?

@Uzlopak
Copy link
Collaborator

Uzlopak commented Feb 5, 2020

Please fix the conflicts

@Uzlopak
Copy link
Collaborator

Uzlopak commented Feb 5, 2020

Please dont create dist files(revert those please)

@sedenardi
Copy link
Author

If dist files are to be omitted from commits, should they be specified in the .gitignore? If not, future contributors will have the same issue and require manual intervention from you or another maintainer (not to mention the manual build that is required after merging if the dist files are to be omitted).

@bwl21
Copy link
Contributor

bwl21 commented Feb 5, 2020

dist files shall be commited in master only.

If dist files are to be omitted from commits, should they be specified in the .gitignore? If not, future contributors will have the same issue and require manual intervention from you or another maintainer (not to mention the manual build that is required after merging if the dist files are to be omitted).

distfiles should e commited in master only in order to avoid merge conflicts. so branches for a merge request shoud not change 'dist'

@sedenardi
Copy link
Author

sedenardi commented Feb 5, 2020

I was mostly commenting that the directive to not commit dist files to feature/fix branches isn't spelled out anywhere (in the README or a separate CONTRIBUTING file), so may be a good idea to prevent it from happening in the future.

I reverted the dist files, and fixed the merge conflicts. Let me know if anything else is needed.

@Uzlopak Uzlopak merged commit 50f43fb into parallax:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants