fix(rpc/trace): trace_filter filting with trace's address #9722
Conversation
crates/rpc/rpc/src/trace.rs
Outdated
| // filter out traces that don't match the filter | ||
| all_traces = all_traces | ||
| .into_iter() | ||
| .filter(|trace| matcher.matches(&trace.trace)) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
I think we need to be a bit more careful here now that we no longer prefilter blocks because this has now all the blocks in memory
perhaps we can apply the filter in the trace_block_until( call instead so we only buffer traces that we need?
also no longer sure about the self.calculate_base_block_reward( should we only do this for blocks that have at least one match?
There was a problem hiding this comment.
Yeah, inside the tracing should be more efficient.
And for the block rewards, I think it's similar to normal traces, simple match should be sufficient.
Btw, do we have any plans to indexing the trace from/to address, similar to erigon's TraceFromIndex and TraceToIndex?
There was a problem hiding this comment.
Btw, do we have any plans to indexing the trace from/to address
nothing final yet, but we're considering it either with or without breaking the db, need to figure out if it's possible to introduce this without requiring a resync
perhaps you can open an issue for this, don't think this is tracked
There was a problem hiding this comment.
Thanks, if we are planning to implement it, I want to have a try
mattsse
added
S-blocked
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
…z#9722) Signed-off-by: jsvisa <[email protected]> Co-authored-by: Matthias Seitz <[email protected]>
waiting for alloy-rs/alloy#1090 to be merged first.
Currently, we're filtering the trace result by transaction's from and to address, but indeed this API should filtering with trace {action, result}'s address, the latter is more useful and meaningful.
eg I want to fetch the traces with the below RPC:
{ "jsonrpc": "2.0", "method": "trace_filter", "id": 67, "params": [ { "fromBlock": "0x134FD29", "toBlock": "0x134FD29", "fromAddress": ["0x6b75d8af000000e20b7a7ddf000ba900b4009a80"], "toAddress": ["0x420690b0736e88ea43373a6dd7e1c8f225050e7b"] } ] }reth's can't produce any results, because https://etherscan.io/address/0x6b75d8af000000e20b7a7ddf000ba900b4009a80 is a contract, no exists in tx's from_address.