-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract init from node-core #8373
Conversation
8efb414
to
5cf3dd6
Compare
ah cool, I was looking for this actually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
only have a style nit
crates/db-common/src/lib.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs the regular lib.rs header including the cfg for unused crates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done! also cleaned up the unused dependencies
42d0916
to
ed3ae98
Compare
92bc01a
to
42d0916
Compare
42d0916
to
08db132
Compare
how can i fix the fmt issue? when i run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last pedantic nit
to format please run cargo +nightly fmt --all
reth-trie.workspace = true | ||
reth-consensus-common.workspace = true | ||
reth-beacon-consensus.workspace = true | ||
reth-etl.workspace = true | ||
reth-codecs.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Co-authored-by: Matthias Seitz <[email protected]>
Resolves #8171 .
Overview
Introduces the
reth-db-common
crate and movesnode-core/init.rs
into this new crate.Test Plan