Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose call method so a consumer can use it #3680

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

joshstevens19
Copy link
Contributor

call and estimate_gas_at were only callable by the crates remove that to allow consumers who install these libs to be able to call it

@mattsse mattsse added the C-debt A section of code is hard to understand or change label Jul 9, 2023
@mattsse mattsse enabled auto-merge July 9, 2023 13:32
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #3680 (4d23005) into main (1330fc1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc/src/eth/api/call.rs 61.95% <100.00%> (-0.73%) ⬇️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.93% <100.00%> (+0.01%) ⬆️
unit-tests 64.10% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.35% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.69% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 94.66% <ø> (ø)
txpool 49.34% <ø> (ø)
networking 77.92% <ø> (+0.03%) ⬆️
rpc 58.12% <100.00%> (-0.03%) ⬇️
consensus 63.35% <ø> (ø)
revm 34.86% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.24% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Jul 9, 2023
Merged via the queue into paradigmxyz:main with commit f116040 Jul 9, 2023
25 checks passed
@joshstevens19 joshstevens19 deleted the fix/expose-call-methods branch July 9, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A section of code is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants