Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add commit to client version #3621

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 6, 2023

closes #2976

adds sha1 to client version, as it's convention

Geth/v1.11.5-stable-a38f4108/linux-amd64/go1.20.2

reth/v0.1.0-alpha.1-428a6dc2f/aarch64-apple-darwin

@mattsse mattsse requested a review from onbjerg as a code owner July 6, 2023 11:16
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 6, 2023
@onbjerg onbjerg added the C-enhancement New feature or request label Jul 6, 2023
@onbjerg onbjerg enabled auto-merge July 6, 2023 11:35
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3621 (837fb36) into main (428a6dc) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/version.rs 90.00% <ø> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.08% <ø> (-0.01%) ⬇️
unit-tests 63.93% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.41% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.91% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 94.66% <ø> (ø)
txpool 49.11% <ø> (ø)
networking 77.87% <ø> (-0.02%) ⬇️
rpc 58.02% <ø> (-0.03%) ⬇️
consensus 62.10% <ø> (ø)
revm 34.90% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.29% <ø> (+0.01%) ⬆️

@onbjerg onbjerg added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 6347aac Jul 6, 2023
@onbjerg onbjerg deleted the matt/add-sha1-to-client-version branch July 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give more info in web3_clientVersion, particularly the commit hash
3 participants