Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(book): document missing CLI arguments #3610

Merged
merged 5 commits into from
Jul 6, 2023
Merged

chore(book): document missing CLI arguments #3610

merged 5 commits into from
Jul 6, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jul 5, 2023 •
edited
Loading

As per the PR title. @leovct #3576 works great, thank you!

@shekhirin shekhirin marked this pull request as ready for review July 5, 2023 17:30
@shekhirin shekhirin requested a review from gakonst as a code owner July 5, 2023 17:30
@shekhirin shekhirin added the C-docs An addition or correction to our documentation label Jul 5, 2023
@shekhirin shekhirin requested a review from onbjerg July 5, 2023 17:33
rkrasiuk
rkrasiuk approved these changes Jul 5, 2023
View reviewed changes
book/cli/node.md
[default: 1]
[default: 1000]

TxPool:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@shekhirin shekhirin changed the title chore(book): document --db-level CLI argument chore(book): document --db-level and fix transaction pool CLI arguments Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Merging #3610 (c90792e) into main (428a6dc) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

see 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.09% <ø> (+<0.01%) ⬆️
unit-tests 63.97% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.41% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.91% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 94.66% <ø> (ø)
txpool 49.73% <ø> (+0.61%) ⬆️
networking 77.89% <ø> (+<0.01%) ⬆️
rpc 58.01% <ø> (-0.04%) ⬇️
consensus 62.10% <ø> (ø)
revm 34.90% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.25% <ø> (-0.03%) ⬇️

@shekhirin shekhirin changed the title chore(book): document --db-level and fix transaction pool CLI arguments chore(book): fix CI & document missing CLI arguments Jul 5, 2023
@onbjerg
Copy link
Member

onbjerg commented Jul 5, 2023

Needs a rebase, I disabled the job because it doesn't account for differences in the node identity between platforms

@shekhirin shekhirin changed the title chore(book): fix CI & document missing CLI arguments chore(book): document missing CLI arguments Jul 6, 2023
@shekhirin shekhirin force-pushed the alexey/book-cli-db-level branch 2 times, most recently from 288a61f to 3e5fcea Compare July 6, 2023 11:23
@onbjerg onbjerg enabled auto-merge July 6, 2023 12:01
@onbjerg onbjerg added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit d9dc9aa Jul 6, 2023
@onbjerg onbjerg deleted the alexey/book-cli-db-level branch July 6, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

@rakita rakita Awaiting requested review from rakita

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shekhirin @onbjerg @mattsse @rkrasiuk