Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stages): use MetricsListener for Execution stage gas metric #3511

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jun 30, 2023

This PR finishes migrating all existing sync-related metrics to using MetricsListener which was introduced in #3483.

@shekhirin shekhirin force-pushed the alexey/execution-stage-metrics branch from 7b792f7 to 98c7001 Compare June 30, 2023 18:32
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #3511 (44cd141) into main (4f32f56) will decrease coverage by 0.14%.
The diff coverage is 29.26%.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/node/mod.rs 10.22% <0.00%> (-0.06%) ⬇️
crates/rpc/rpc/src/eth/api/fees.rs 48.41% <0.00%> (ø)
crates/rpc/rpc/src/eth/pubsub.rs 7.38% <0.00%> (ø)
crates/stages/src/metrics/listener.rs 0.00% <0.00%> (ø)
crates/stages/src/metrics/sync_metrics.rs 0.00% <0.00%> (ø)
crates/storage/libmdbx-rs/src/cursor.rs 90.45% <ø> (ø)
crates/transaction-pool/src/lib.rs 36.00% <ø> (ø)
crates/transaction-pool/src/test_utils/mod.rs 100.00% <ø> (+5.55%) ⬆️
crates/transaction-pool/src/traits.rs 5.12% <0.00%> (-0.14%) ⬇️
crates/transaction-pool/src/noop.rs 11.38% <11.38%> (ø)
... and 17 more

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.22% <18.53%> (-0.02%) ⬇️
unit-tests 63.89% <22.43%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.00% <0.00%> (-0.02%) ⬇️
blockchain tree 81.25% <75.00%> (ø)
pipeline 86.77% <31.57%> (-0.21%) ⬇️
storage (db) 73.62% <95.23%> (-0.21%) ⬇️
trie 95.64% <100.00%> (ø)
txpool 49.46% <10.93%> (-1.69%) ⬇️
networking 77.94% <100.00%> (+0.07%) ⬆️
rpc 57.89% <72.22%> (+0.01%) ⬆️
consensus 62.58% <ø> (ø)
revm 34.99% <100.00%> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.48% <ø> (-0.02%) ⬇️

@shekhirin shekhirin changed the title refactor(stages): use MetricsListener for Execution gas metric refactor(stages): use MetricsListener for Execution stage gas metric Jun 30, 2023
@gakonst
Copy link
Member

gakonst commented Jul 3, 2023

gm @shekhirin plans here / next steps?

@shekhirin shekhirin added C-enhancement New feature or request A-staged-sync Related to staged sync (pipelines and stages) A-observability Related to tracing, metrics, logs and other observability tools C-debt A section of code is hard to understand or change and removed C-enhancement New feature or request labels Jul 3, 2023
@shekhirin shekhirin marked this pull request as ready for review July 3, 2023 12:19
@shekhirin shekhirin marked this pull request as draft July 3, 2023 12:20
@shekhirin
Copy link
Collaborator Author

gm @shekhirin plans here / next steps?

tested, RFR

@shekhirin shekhirin marked this pull request as ready for review July 3, 2023 12:46
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - clean. I really like this pattern.

@gakonst gakonst added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit f3c7a82 Jul 6, 2023
26 checks passed
@gakonst gakonst deleted the alexey/execution-stage-metrics branch July 6, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-staged-sync Related to staged sync (pipelines and stages) C-debt A section of code is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants